Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dubbo-4479]Delete unused code. defaultPort can not be null. #4479 #4480

Merged
merged 1 commit into from
Jul 5, 2019
Merged

[Dubbo-4479]Delete unused code. defaultPort can not be null. #4479 #4480

merged 1 commit into from
Jul 5, 2019

Conversation

TingSky
Copy link
Contributor

@TingSky TingSky commented Jul 5, 2019

What is the purpose of the change

Delete unused code

Verifying this change

First PR

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #4480 into master will increase coverage by 0.63%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4480      +/-   ##
============================================
+ Coverage     62.34%   62.98%   +0.63%     
  Complexity      450      450              
============================================
  Files           791      770      -21     
  Lines         34852    33005    -1847     
  Branches       5457     5216     -241     
============================================
- Hits          21730    20789     -941     
+ Misses        10624     9823     -801     
+ Partials       2498     2393     -105
Impacted Files Coverage Δ Complexity Δ
...in/java/org/apache/dubbo/config/ServiceConfig.java 58.42% <100%> (+0.21%) 0 <0> (ø) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-8.7%) 0% <0%> (ø)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
...a/org/apache/dubbo/common/json/ParseException.java
...o/rpc/protocol/thrift/DubboClassNameGenerator.java
.../java/org/apache/dubbo/common/json/JSONObject.java
.../java/org/apache/dubbo/common/json/JSONWriter.java
.../apache/dubbo/rpc/protocol/thrift/ThriftUtils.java
.../java/org/apache/dubbo/common/json/JSONReader.java
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c4b931...c872164. Read the comment docs.

@TingSky TingSky mentioned this pull request Jul 5, 2019
Closed
CrazyHZM
CrazyHZM approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit 46215d2 into apache:master Jul 5, 2019
@dubbo-bot dubbo-bot mentioned this pull request Jul 12, 2019
Closed
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
@TingSky @rolandhe
defaultPort can not be null, delete unuse code. (apache#4480)
e161c31
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
@TingSky @rolandhe
defaultPort can not be null, delete unuse code. (apache#4480)
a121421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrazyHZM CrazyHZM CrazyHZM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TingSky @codecov-io @CrazyHZM